mdiluz/rove
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix up gocritic issues

Browse source
This commit is contained in:
Marc Di Luzio 2020-06-10 12:32:15 +01:00
parent 2ee68e74ac
commit 14c4e61660
9 changed files with 72 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

10
pkg/rove/http.go
View file

@ -13,12 +13,12 @@ type Server string
// GET performs a GET request
func (s Server) GET(path string, out interface{}) error {
url := url.URL{
u := url.URL{
Scheme: "http",
Host: string(s),
Path: path,
}
if resp, err := http.Get(url.String()); err != nil {
if resp, err := http.Get(u.String()); err != nil {
return err
} else if resp.StatusCode != http.StatusOK {
@ -30,8 +30,8 @@ func (s Server) GET(path string, out interface{}) error {
}
// POST performs a POST request
func (s Server) POST(path string, in interface{}, out interface{}) error {
url := url.URL{
func (s Server) POST(path string, in, out interface{}) error {
u := url.URL{
Scheme: "http",
Host: string(s),
Path: path,
@ -45,7 +45,7 @@ func (s Server) POST(path string, in interface{}, out interface{}) error {
}
// Set up the request
req, err := http.NewRequest("POST", url.String(), bytes.NewReader(marshalled))
req, err := http.NewRequest("POST", u.String(), bytes.NewReader(marshalled))
if err != nil {
return err
}