mdiluz/rove
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Refactor tiles to objects to be re-used

Browse source
This commit is contained in:
Marc Di Luzio 2020-06-26 19:45:24 +01:00
parent 8b1eca0aee
commit 2846ed796e
6 changed files with 69 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

22
pkg/game/world.go
View file

@ -13,6 +13,7 @@ import (
"github.com/mdiluz/rove/pkg/atlas"
"github.com/mdiluz/rove/pkg/bearing"
"github.com/mdiluz/rove/pkg/maths"
"github.com/mdiluz/rove/pkg/objects"
"github.com/mdiluz/rove/pkg/vector"
)
@ -112,7 +113,7 @@ func (w *World) SpawnRover() (uuid.UUID, error) {
if tile, err := w.Atlas.GetTile(rover.Pos); err != nil {
return uuid.Nil, err
} else {
if !atlas.IsBlocking(tile) {
if !objects.IsBlocking(tile) {
break
} else {
// Try and spawn to the east of the blockage
@ -136,7 +137,7 @@ func (w *World) DestroyRover(id uuid.UUID) error {
if i, ok := w.Rovers[id]; ok {
// Clear the tile
if err := w.Atlas.SetTile(i.Pos, atlas.TileEmpty); err != nil {
if err := w.Atlas.SetTile(i.Pos, objects.Empty); err != nil {
return fmt.Errorf("coudln't clear old rover tile: %s", err)
}
delete(w.Rovers, id)
@ -212,7 +213,7 @@ func (w *World) WarpRover(id uuid.UUID, pos vector.Vector) error {
// Check the tile is not blocked
if tile, err := w.Atlas.GetTile(pos); err != nil {
return fmt.Errorf("coudln't get state of destination rover tile: %s", err)
} else if atlas.IsBlocking(tile) {
} else if objects.IsBlocking(tile) {
return fmt.Errorf("can't warp rover to occupied tile, check before warping")
}
@ -236,7 +237,7 @@ func (w *World) MoveRover(id uuid.UUID, b bearing.Bearing) (vector.Vector, error
// Get the tile and verify it's empty
if tile, err := w.Atlas.GetTile(newPos); err != nil {
return vector.Vector{}, fmt.Errorf("couldn't get tile for new position: %s", err)
} else if !atlas.IsBlocking(tile) {
} else if !objects.IsBlocking(tile) {
// Perform the move
i.Pos = newPos
w.Rovers[id] = i
@ -255,18 +256,19 @@ func (w *World) RoverStash(id uuid.UUID) (byte, error) {
if r, ok := w.Rovers[id]; ok {
if tile, err := w.Atlas.GetTile(r.Pos); err != nil {
return atlas.TileEmpty, err
return objects.Empty, err
} else {
if tile != atlas.TileEmpty {
// TODO: Get if item grabbable and clear tile
if tile != objects.Empty {
r.Inventory = append(r.Inventory, Item{Type: tile})
}
}
} else {
return atlas.TileEmpty, fmt.Errorf("no rover matching id")
return objects.Empty, fmt.Errorf("no rover matching id")
}
return atlas.TileEmpty, nil
return objects.Empty, nil
}
// RadarFromRover can be used to query what a rover can currently see
@ -327,12 +329,12 @@ func (w *World) RadarFromRover(id uuid.UUID) ([]byte, error) {
if dist.X <= r.Attributes.Range && dist.Y <= r.Attributes.Range {
relative := r.Pos.Added(radarMin.Negated())
index := relative.X + relative.Y*radarSpan
radar[index] = atlas.TileRover
radar[index] = objects.Rover
}
}
// Add this rover
radar[len(radar)/2] = atlas.TileRover
radar[len(radar)/2] = objects.Rover
return radar, nil
} else {

16
pkg/game/world_test.go
View file

@ -3,8 +3,8 @@ package game
import (
"testing"
"github.com/mdiluz/rove/pkg/atlas"
"github.com/mdiluz/rove/pkg/bearing"
"github.com/mdiluz/rove/pkg/objects"
"github.com/mdiluz/rove/pkg/vector"
"github.com/stretchr/testify/assert"
)
@ -85,7 +85,7 @@ func TestWorld_GetSetMovePosition(t *testing.T) {
assert.Equal(t, pos, newPos, "Failed to correctly move position for rover")
// Place a tile in front of the rover
assert.NoError(t, world.Atlas.SetTile(vector.Vector{X: 0, Y: 2}, atlas.TileLargeRock))
assert.NoError(t, world.Atlas.SetTile(vector.Vector{X: 0, Y: 2}, objects.LargeRock))
newPos, err = world.MoveRover(a, b)
assert.Equal(t, pos, newPos, "Failed to correctly not move position for rover into wall")
}
@ -132,12 +132,12 @@ func TestWorld_RadarFromRover(t *testing.T) {
PrintTiles(radar)
// Test all expected values
assert.Equal(t, atlas.TileRover, radar[1+fullRange])
assert.Equal(t, atlas.TileRover, radar[4+4*fullRange])
assert.Equal(t, objects.Rover, radar[1+fullRange])
assert.Equal(t, objects.Rover, radar[4+4*fullRange])
for i := 0; i < 8; i++ {
assert.Equal(t, atlas.TileLargeRock, radar[i])
assert.Equal(t, atlas.TileLargeRock, radar[i+(7*9)])
assert.Equal(t, atlas.TileLargeRock, radar[i*9])
assert.Equal(t, atlas.TileLargeRock, radar[(i*9)+7])
assert.Equal(t, objects.LargeRock, radar[i])
assert.Equal(t, objects.LargeRock, radar[i+(7*9)])
assert.Equal(t, objects.LargeRock, radar[i*9])
assert.Equal(t, objects.LargeRock, radar[(i*9)+7])
}
}