From 50cc8b5dbf3cddfd1414da120ab957edb03b42dd Mon Sep 17 00:00:00 2001
From: Marc Di Luzio <marc.diluzio@gmail.com>
Date: Sat, 6 Jun 2020 18:44:24 +0100
Subject: [PATCH] Minor cleanups
---
cmd/rove-server/Dockerfile | 1 -
cmd/rove/main_test.go | 2 +-
pkg/server/routes_test.go | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/cmd/rove-server/Dockerfile b/cmd/rove-server/Dockerfile
index 7d1b276..7ca6727 100644
--- a/cmd/rove-server/Dockerfile
+++ b/cmd/rove-server/Dockerfile
@@ -8,7 +8,6 @@ RUN go mod download
# For /usr/share/dict/words
RUN apt-get update && apt-get install -y wamerican
-
RUN go build -o rove-server -ldflags="-X 'github.com/mdiluz/rove/pkg/version.Version=$(git describe --always --long --dirty --tags)'" cmd/rove-server/main.go
CMD [ "./rove-server" ]
diff --git a/cmd/rove/main_test.go b/cmd/rove/main_test.go
index ec4c2c0..aa51607 100644
--- a/cmd/rove/main_test.go
+++ b/cmd/rove/main_test.go
@@ -65,7 +65,7 @@ func Test_InnerMain(t *testing.T) {
assert.NoError(t, InnerMain("register"))
// We've not spawned a rover yet so these should fail
- assert.Error(t, InnerMain("command")) // Currently not erroring, needs investigation
+ assert.Error(t, InnerMain("command"))
assert.Error(t, InnerMain("radar"))
assert.Error(t, InnerMain("rover"))
diff --git a/pkg/server/routes_test.go b/pkg/server/routes_test.go
index 34929dc..ab21bf1 100644
--- a/pkg/server/routes_test.go
+++ b/pkg/server/routes_test.go
@@ -180,5 +180,5 @@ func TestHandleRover(t *testing.T) {
t.Errorf("got false for /rover: %s", status.Error)
}
- // TODO: Verify the radar information
+ // TODO: Verify the rover information
}